[webkit-reviews] review denied: [Bug 62807] SVGAnimation should use direct unit animation for SVGAngle : [Attachment 97481] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 62807: SVGAnimation should use direct unit animation for SVGAngle
https://bugs.webkit.org/show_bug.cgi?id=62807

Attachment 97481: Patch
https://bugs.webkit.org/attachment.cgi?id=97481&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97481&action=review

r- for now since it will fail to compile on a lot of platforms right now.

> Source/WebCore/ChangeLog:9
> +	   This patch continues the convertion to the new concept of
SVGAnimatorFactory with SVGAngle. We can animte the SVG primitive datatype
SVGAngle

conversion && animate

> Source/WebCore/ChangeLog:22
> +	   * WebCore.xcodeproj/project.pbxproj:

You are missing at least vcproj and .pro files!

> Source/WebCore/CMakeLists.txt:1652
> +	   svg/SVGAnimatedAnlge.cpp

typo!