[webkit-reviews] review denied: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 97455] 0001 - Add SVGElement::reportAttributeParsingErrorIfNeeded

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Tim Horton <timothy_horton at apple.com>'s
request for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 97455: 0001 - Add SVGElement::reportAttributeParsingErrorIfNeeded
https://bugs.webkit.org/attachment.cgi?id=97455&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97455&action=review

> Source/WebCore/svg/SVGParsingError.h:19
> +/*
> + * Copyright (C) Research In Motion Limited 2011. All rights reserved.
> + * Copyright (C) Apple, Inc. 2011. All rights reserved.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License

> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + */

In general, the license we like to use for new content is the two clause BSD
one at found http://www.webkit.org/coding/bsd-license.html.

> Source/WebCore/svg/SVGParsingError.h:32
> +typedef enum {
> +    NoError = 0,
> +    ParsingAttributeFailedError,
> +    NegativeValueForbiddenError
> +} SVGParsingError;

This is c++, so the syntax for an enum is:

enum Foo {
    Bar
};

No typedef needed.