[webkit-reviews] review granted: [Bug 60687] [GTK] Replace GdkRectangle by cairo_rectangle_int_t : [Attachment 95720] Proposed Patch5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 07:51:34 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Joone Hur
<joone.hur at collabora.co.uk>'s request for review:
Bug 60687: [GTK] Replace GdkRectangle by cairo_rectangle_int_t
https://bugs.webkit.org/show_bug.cgi?id=60687

Attachment 95720: Proposed Patch5
https://bugs.webkit.org/attachment.cgi?id=95720&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
This looks fine except that I think you should remove the OwnPtr and IntRect
changes until they are actually used. It's weird to check them in as dead code.
I think this patch is fine just bumping the Cairo dependency and then depending
on it in a few remaining places. Please make these changes before landing.


More information about the webkit-reviews mailing list