[webkit-reviews] review denied: [Bug 61915] [EFL][WK2] Add efl port's ewk_view files : [Attachment 97399] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 16 07:28:12 PDT 2011
Leandro Pereira <leandro at profusion.mobi> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 61915: [EFL][WK2] Add efl port's ewk_view files
https://bugs.webkit.org/show_bug.cgi?id=61915
Attachment 97399: Patch
https://bugs.webkit.org/attachment.cgi?id=97399&action=review
------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=97399&action=review
LGTM, just some small nits.
> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:354
> + if (sd->changed.size) {
> + if (priv->pageClient)
> + priv->pageClient->page()->drawingArea()->setSize(IntSize(w, h),
IntSize());
> + sd->view.w = w;
> + sd->view.h = h;
> + }
> + sd->changed.size = EINA_FALSE;
You could move the attribution to sd->changed.size inside the if block. Same
below.
More information about the webkit-reviews
mailing list