[webkit-reviews] review denied: [Bug 56990] rename -webkit-any to -webkit-matches : [Attachment 97414] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 02:11:52 PDT 2011


MORITA Hajime <morrita at google.com> has denied Kentaro Hara
<haraken at google.com>'s request for review:
Bug 56990: rename -webkit-any to -webkit-matches
https://bugs.webkit.org/show_bug.cgi?id=56990

Attachment 97414: Patch
https://bugs.webkit.org/attachment.cgi?id=97414&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review

This review is just for nit-picking. I have no idea if this change is desirable
so I'd like hear from expert folks...

> LayoutTests/ChangeLog:4
> +

Could you explain your change briefly?

> LayoutTests/ChangeLog:8
> +	   Need a short description and bug URL (OOPS!)

We don't need this line.

> Source/WebCore/ChangeLog:7
> +

You should mention about tests, even if you do't add any new test.


More information about the webkit-reviews mailing list