[webkit-reviews] review granted: [Bug 55829] Add information about how the value changed to Element::attributeChanged() : [Attachment 93546] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 55829: Add information about how the value changed to
Element::attributeChanged()
https://bugs.webkit.org/show_bug.cgi?id=55829

Attachment 93546: Patch
https://bugs.webkit.org/attachment.cgi?id=93546&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=93546&action=review

Giving r=me, but avoid duplicating that code.

> Source/WebCore/dom/Element.cpp:690
> +	   bool sameValue = old->value() == value;
> +	   if (!sameValue) {
> +	       if (Attr* attrNode = old->attr())
> +		   attrNode->setValue(value);
> +	       else
> +		   old->setValue(value);
> +	   }
> +	   if (!sameValue || fireEveryAttributeChange(old))
> +	       attributeChanged(old);

Pull this into a little static helper please to avoid duplication.