[webkit-reviews] review denied: [Bug 62027] nrwt: handle missing httpd cleanly : [Attachment 97244] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kristóf Kosztyó
<Kosztyo.Kristof at stud.u-szeged.hu>'s request for review:
Bug 62027: nrwt: handle missing httpd cleanly
https://bugs.webkit.org/show_bug.cgi?id=62027

Attachment 97244: proposed fix
https://bugs.webkit.org/attachment.cgi?id=97244&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
The idea is good, but this is is the wrong place to check for this ... this
check would be done in a worker thread after the main test suite has already
started running. 

There is a check_sys_deps() function on the Port object that is called prior to
running the tests. It is passed a flag indicating whether we need an http
server to run the tests or not. You should probably move this check to that
routine instead. See  Tools/Scripts/webkitpy/layout_tests/port/base.py:185.
Bonus points for modifying the chromium.py implementation as well :)


Also, NRWT doesn't actually support the --no-http flag yet, so we should either
add that, file a bug to fix that, or not mention it in this error message.