[webkit-reviews] review requested: [Bug 62745] Convert WebNSFileManagerExtras.m to Objective-C++ : [Attachment 97341] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 12:15:35 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 62745: Convert WebNSFileManagerExtras.m to Objective-C++
https://bugs.webkit.org/show_bug.cgi?id=62745

Attachment 97341: Patch
https://bugs.webkit.org/attachment.cgi?id=97341&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:
(WebNSFileManagerExtras.m): Rename to WebNSFileManagerExtras.mm
and change file type to Objective-C++.

Source/WebKit/mac:

* Misc/WebNSFileManagerExtras.mm: Renamed from
Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
(-[NSFileManager _webkit_carbonPathForPath:]):
(setMetaData):
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Added static_cast<MetaDataInfo *>.
(-[NSFileManager _webkit_startupVolumeName]):
(fileExists):
(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
---
 5 files changed, 217 insertions(+), 192 deletions(-)


More information about the webkit-reviews mailing list