[webkit-reviews] review denied: [Bug 62730] Python checks for sys.platform have to be relaxed and/or extended for Linux >=3.0-rc1 support : [Attachment 97317] WebKit-linux3-support.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 10:27:39 PDT 2011


Tony Chang <tony at chromium.org> has denied Torsten <gentoo at tk-webart.de>'s
request for review:
Bug 62730: Python checks for sys.platform have to be relaxed and/or extended
for Linux >=3.0-rc1 support
https://bugs.webkit.org/show_bug.cgi?id=62730

Attachment 97317: WebKit-linux3-support.patch
https://bugs.webkit.org/attachment.cgi?id=97317&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97317&action=review

Other than the gyp changes, the rest looks fine.

> Source/ThirdParty/ChangeLog:12
> +	   * gyp/pylib/gyp/__init__.py:

We fixed gyp separately right?	I think we shouldn't change this ThirdParty
code and just update to a newer version of gyp that includes the fix.


More information about the webkit-reviews mailing list