[webkit-reviews] review granted: [Bug 62648] MediaPlayerPrivate should not know about application cache : [Attachment 97172] Patch, this time with valid ChangeLog!

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 62648: MediaPlayerPrivate should not know about application cache
https://bugs.webkit.org/show_bug.cgi?id=62648

Attachment 97172: Patch, this time with valid ChangeLog!
https://bugs.webkit.org/attachment.cgi?id=97172&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97172&action=review

I would love to have a test case that tries to load a non-media resource into a
<video> element. And maybe some more explicit error handling for that - we now
rely on a failure to load from an empty path when the resource hasn't been
stored in a file due to a wrong MIME type.

> Source/WebCore/html/HTMLMediaElement.cpp:687
> +    url.setProtocol("file");
> +    url.setPath(path);

Did you verify that this works on Windows?

> Source/WebCore/html/HTMLMediaElement.cpp:718
> +	       mediaLoadingFailed(MediaPlayer::NetworkError);

Please file a bug about the other cases that you found where we lack this call.