[webkit-reviews] review denied: [Bug 62444] [EFL][WK2] Add BackingStoreEfl for WebKit2 EFL port : [Attachment 97229] Patch

[bugzilla-daemon at webkit.org]

Leandro Pereira <leandro at profusion.mobi> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 62444: [EFL][WK2] Add BackingStoreEfl for WebKit2 EFL port
https://bugs.webkit.org/show_bug.cgi?id=62444

Attachment 97229: Patch
https://bugs.webkit.org/attachment.cgi?id=97229&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=97229&action=review

Informal r-.

> Source/WebKit2/UIProcess/efl/BackingStoreEfl.cpp:40
> +void BackingStore::paint(cairo_t* context, const IntRect& rect)

Can't this be shared with other Cairo-using ports?

> Source/WebKit2/UIProcess/efl/BackingStoreEfl.cpp:48
> +void BackingStore::incorporateUpdate(ShareableBitmap* bitmap, const
UpdateInfo& updateInfo)

If the platform-independent part of this function is also similar to other
Cairo-using ports, consider splitting this method into two, and doing something
along the lines of:

   if (!m_backingStoreSurface)
      platformCreateBackingStoreSurface();

   scroll(...); ...

I'd talk with WinCairo and GTK+ devs before attempting this, though.

> Source/WebKit2/UIProcess/efl/BackingStoreEfl.cpp:77
> +void BackingStore::scroll(const IntRect& scrollRect, const IntSize&
scrollOffset)

This method could also be shared with GTK+ or other Cairo-using ports: the only
part here that depends on Evas is obtaining the dimentions of the view object,
so perhaps a little refactoring would make this platform-independent?