[webkit-reviews] review denied: [Bug 62642] [Efl] Add EflOwnPtr to wtf : [Attachment 97131] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 62642: [Efl] Add EflOwnPtr to wtf
https://bugs.webkit.org/show_bug.cgi?id=62642

Attachment 97131: Patch
https://bugs.webkit.org/attachment.cgi?id=97131&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97131&action=review

> Source/JavaScriptCore/wtf/efl/EflOwnPtr.cpp:32
> +{
> +    evas_object_del(ptr);
> +}

Are Evas Objects always reference counted [1]? If so it would probably be more
correct to specialize RefPtr instead.

1.
http://docs.enlightenment.org/auto/evas/group__Evas__Object__Group__Basic.html#
gaa22895e88e2cb157b9c38a6d3ce10723

>> Source/JavaScriptCore/wtf/efl/EflOwnPtr.h:132
>> +}
> 
> I think we just need this type specialization for OwnPtr and then OwnPtr will
work like a charm for what you want.

Totally agree with Eric here. Just be sure to always use new when allocating
memory with OwnPtr.