[webkit-reviews] review denied: [Bug 61038] Web Inspector: Serious performance regression during continuous focused element style updates : [Attachment 96567] [PATCH] Rebase

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 61038: Web Inspector: Serious performance regression during continuous
focused element style updates
https://bugs.webkit.org/show_bug.cgi?id=61038

Attachment 96567: [PATCH] Rebase
https://bugs.webkit.org/attachment.cgi?id=96567&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96567&action=review

A number of small nits and a test request.

> Source/WebCore/inspector/Inspector.json:787
> +		   "id": "DOMNodeAttributes",

Attributes. We can also rename DOMNode and DOMEventListener since type names
have domain scope.

> Source/WebCore/inspector/Inspector.json:790
> +		       { "name": "id", "type": "integer", "description": "Node
id." },

Element id to get attributes for.

> Source/WebCore/inspector/Inspector.json:987
> +		   "name": "getNodeAttributes",

getAttributes

> Source/WebCore/inspector/Inspector.json:1013
> +		       { "name": "nodeId", "type": "integer", "description":
"Id of the node that has changed." }

You might want to leave this as is for performance considerations.

> Source/WebCore/inspector/Inspector.json:1018
> +		   "name": "inlineStyleInvalidated",

Please add a test for this new event.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:255
> +    m_domAgent->notifyStyleAttrInvalidated(elements);

StyleAttributeInvalidated (no abbreaviations in WebCore)