[webkit-reviews] review denied: [Bug 62714] Web Inspector: breakpointsWithoutSourceFile values should be a maps, not arrays. : [Attachment 97272] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 15 03:52:17 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 62714: Web Inspector: breakpointsWithoutSourceFile values should be a maps,
not arrays.
https://bugs.webkit.org/show_bug.cgi?id=62714
Attachment 97272: Patch.
https://bugs.webkit.org/attachment.cgi?id=97272&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97272&action=review
> Source/WebCore/inspector/front-end/Settings.js:-82
> - this._migrateSettings();
This code should be preserved to get rid of existing duplicates. Otherwise,
inspector will be slow until next time breakpoints are persisted and override
existing settings. r- for this.
More information about the webkit-reviews
mailing list