[webkit-reviews] review denied: [Bug 62711] [EFL][WK2] Add missing functions of EFL port's PageClientImpl : [Attachment 97266] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 15 03:22:45 PDT 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 62711: [EFL][WK2] Add missing functions of EFL port's PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=62711
Attachment 97266: Patch
https://bugs.webkit.org/attachment.cgi?id=97266&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review
> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170
> +IntPoint PageClientImpl::screenToWindow(const IntPoint&)
> +{
> + notImplemented();
> + return IntPoint();
> +}
Maybe returning the given point makes more sense. This is a conversion method
and converting it to the same will surely work better than converting
everything to 0, 0
More information about the webkit-reviews
mailing list