[webkit-reviews] review canceled: [Bug 61073] Teach WebKit2 about window.internals : [Attachment 97232] Patch that uses @loader_path

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has canceled Dominic Cooney
<dominicc at chromium.org>'s request for review:
Bug 61073: Teach WebKit2 about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61073

Attachment 97232: Patch that uses @loader_path
https://bugs.webkit.org/attachment.cgi?id=97232&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97232&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26099
> +				INSTALL_PATH =
"$(INSTALL_PATH_$(REAL_PLATFORM_NAME))";

These should all be set in the .xcconfig file.

> Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:93
> +/* Begin PBXCopyFilesBuildPhase section */
> +		A6ED12C213A8787A002D845D /* Copy WebCoreTestSupport into Bundle
*/ = {
> +			isa = PBXCopyFilesBuildPhase;
> +			buildActionMask = 2147483647;
> +			dstPath = "";
> +			dstSubfolderSpec = 6;
> +			files = (
> +				A6ED12BD13A87876002D845D /*
libWebCoreTestSupport.dylib in Copy WebCoreTestSupport into Bundle */,
> +			);
> +			name = "Copy WebCoreTestSupport into Bundle";
> +			runOnlyForDeploymentPostprocessing = 0;
> +		};
> +/* End PBXCopyFilesBuildPhase section */

I didn’t think this was necessary for