[webkit-reviews] review denied: [Bug 62680] markup-dump conversion + rename: editing/deleting/5408255.html : [Attachment 97202] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Wyatt Carss <wcarss at chromium.org>'s
request for review:
Bug 62680: markup-dump conversion + rename: editing/deleting/5408255.html
https://bugs.webkit.org/show_bug.cgi?id=62680

Attachment 97202: Patch
https://bugs.webkit.org/attachment.cgi?id=97202&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97202&action=review

> LayoutTests/ChangeLog:8
> +	   editing/deleting/5408255.html is now
editing/deleting/delete-button-failure.html

delete-button-failure sounds too general.  Since this test is concerned with
-webkit-user-select: none, I'd include that in the name.  Something like
delete-button-with-select-none.

> LayoutTests/editing/deleting/delete-button-failure.html:26
> +    if(!deleteButton && !listElement)
> +	   document.getElementById("test").innerHTML = "Success";

I don't think not having list item necessarily makes this test pass because it
could be leaving other elements such as ul or text. r- because of this.