[webkit-reviews] review denied: [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events : [Attachment 97187] Adds a console message for blocked alerts. Adds Chromium-specific test expectations.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 16:42:35 PDT 2011


Adam Barth <abarth at webkit.org> has denied Sreeram Ramachandran
<sreeram at chromium.org>'s request for review:
Bug 56397: Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Attachment 97187: Adds a console message for blocked alerts. Adds
Chromium-specific test expectations.
https://bugs.webkit.org/attachment.cgi?id=97187&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97187&action=review

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:942
> +    String logMessage = "Blocked ";

StringBuilder plz.


More information about the webkit-reviews mailing list