[webkit-reviews] review granted: [Bug 61993] [EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent, NativeWebWheelEvent and NativeWebKeyboardEvent : [Attachment 97105] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 15:26:00 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 61993: [EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent,
NativeWebWheelEvent and NativeWebKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=61993

Attachment 97105: Patch
https://bugs.webkit.org/attachment.cgi?id=97105&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97105&action=review

>> Source/WebKit2/ChangeLog:8
>> +	    add native mouse and keyboard event classes to convert EFL's events
to NativeWebEvent.
> 
> Start sentences with uppercase letters.

Add*

> Source/WebKit2/Shared/efl/WebEventFactory.cpp:46
> +enum {
> +    LeftButton = 1,
> +    MiddleButton = 2,
> +    RightButton = 3
> +};

Is this always the case for all mouse types?


More information about the webkit-reviews mailing list