[webkit-reviews] review granted: [Bug 48293] Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html : [Attachment 96979] Proposed fix: Same as previously with a comment about destination-out.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 15:00:37 PDT 2011


James Robinson <jamesr at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 48293: Fix
LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html
https://bugs.webkit.org/show_bug.cgi?id=48293

Attachment 96979: Proposed fix: Same as previously with a comment about
destination-out.
https://bugs.webkit.org/attachment.cgi?id=96979&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I think you'll need to update the pixel baselines for at least
canvas-composited.html (note that there are 7 different -expected.png files for
this).	Could you add = IMAGE lines for chromium's test_expectations.txt at
least so this doesn't make the bots red, and then rebaseline after landing? 
The other ports don't run pixel tests on the bots so it's very difficult to
update expectations for those.

Other than that this looks great.


More information about the webkit-reviews mailing list