[webkit-reviews] review denied: [Bug 58191] Use console.log() instead of alert() in unload handlers in tests : [Attachment 97157] Updated test expectation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 14 13:14:15 PDT 2011
Ojan Vafai <ojan at chromium.org> has denied Sreeram Ramachandran
<sreeram at chromium.org>'s request for review:
Bug 58191: Use console.log() instead of alert() in unload handlers in tests
https://bugs.webkit.org/show_bug.cgi?id=58191
Attachment 97157: Updated test expectation
https://bugs.webkit.org/attachment.cgi?id=97157&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Can we instead make it so that an alert call during an unload handler logs an
error to the console? That would make it so we don't need to modify these tests
and would have the added benefit of being more friendly to web developers who
try to use alert in unload handlers for debugging.
More information about the webkit-reviews
mailing list