[webkit-reviews] review granted: [Bug 62658] Constant array literals result in unnecessarily large amounts of code : [Attachment 97150] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 14 12:07:16 PDT 2011
Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 62658: Constant array literals result in unnecessarily large amounts of
code
https://bugs.webkit.org/show_bug.cgi?id=62658
Attachment 97150: Patch
https://bugs.webkit.org/attachment.cgi?id=97150&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97150&action=review
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1551
> + unsigned checkLength = 0;
This should be #ifndef NDEBUG, or, um, !ASSERT_DISABLED?. Y'know.
More information about the webkit-reviews
mailing list