[webkit-reviews] review granted: [Bug 62614] rwt: handle worker exceptions cleanly : [Attachment 97049] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 62614: rwt: handle worker exceptions cleanly
https://bugs.webkit.org/show_bug.cgi?id=62614

Attachment 97049: Patch
https://bugs.webkit.org/attachment.cgi?id=97049&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97049&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:695
> +	   except WorkerException, e:

Nit: e looks unused, maybe remove it or re-raise it?

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:702
>	       raise

Should we re-raise the exception here too?

>>> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:1323
>>> +		 raise exception_type, exception_value
>> 
>> deprecated form of raising exception  [pep8/W602] [5]
> 
> The code is correct, and I don't know if there's a way to suppress this
warning given whatever lint tool we're using, or if there's another way to
re-raise this error, but otherwise this warning can be ignored, I think.

Can you do raise exception_type(exception_value) or does that not always work?

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py:108
>	       _log.debug("%s done with message loop%s" % (self._name,
exception_msg))

Nit: Should the prefix ", " be moved into this log message and removed from
exception_msg?