[webkit-reviews] review granted: [Bug 62627] [GTK] Move the code to show the context menu from WebKitWebViewBase to WebContextMenuProxyGtk : [Attachment 97092] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 14 07:58:32 PDT 2011
Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 62627: [GTK] Move the code to show the context menu from WebKitWebViewBase
to WebContextMenuProxyGtk
https://bugs.webkit.org/show_bug.cgi?id=62627
Attachment 97092: Patch
https://bugs.webkit.org/attachment.cgi?id=97092&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97092&action=review
Thank you for the cleanup!
> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:89
> + gtk_menu_popdown(m_popup);
I guess this fix is tacked on? It's simple enough that I think it's fine for
this patch. For more complicated fixes it's probably better to make seperate
bugs.
More information about the webkit-reviews
mailing list