[webkit-reviews] review denied: [Bug 61205] Web Inspector: Cache XHR content in backend, do not use initialContentSet for XHRs. : [Attachment 96743] patch with fixes + added assertion to NetworkResourcesData::resourceCreated

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 61205: Web Inspector: Cache XHR content in backend, do not use
initialContentSet for XHRs.
https://bugs.webkit.org/show_bug.cgi?id=61205

Attachment 96743: patch with fixes + added assertion to
NetworkResourcesData::resourceCreated
https://bugs.webkit.org/attachment.cgi?id=96743&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96743&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:432
> +	   *errorString = "No resource with given loaderId and identifier
found";

Where is loaderId provided?

> Source/WebCore/inspector/InspectorResourceAgent.cpp:440
> +	       *errorString = "No data found for resource with given loaderId
and identifier";

ditto

> Source/WebCore/inspector/NetworkResourcesData.cpp:93
> +	   resourceData->content.append(content);

Can we do it a bit more efficiently? (a builder?)

> Source/WebCore/inspector/front-end/NetworkPanel.js:814
> +		       resource.forbidContentRequestsFromNetworkAgent();

Can we clear the ids in this case?