[webkit-reviews] review denied: [Bug 53359] Web Inspector: Allow the console to persist on page refresh or navigation : [Attachment 96666] Moves setting to context menu, clears backend messages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 05:48:12 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Sreeram Ramachandran
<sreeram at chromium.org>'s request for review:
Bug 53359: Web Inspector: Allow the console to persist on page refresh or
navigation
https://bugs.webkit.org/show_bug.cgi?id=53359

Attachment 96666: Moves setting to context menu, clears backend messages
https://bugs.webkit.org/attachment.cgi?id=96666&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96666&action=review

A couple of nits, otherwise looks good.

> Source/WebCore/ChangeLog:13
> +	   No new tests. (OOPS!)

I think it is possible to test this. Check out
LayoutTests/inspector/console/console-log-toString-object.html on how to reload
a page and dump console messages afterwards. function test() is executed within
inspector context, so you should be able to set your preserve flag there prior
to calling the reload.

> Source/WebCore/inspector/front-end/ConsoleView.js:465
> +	  
contextMenu.appendCheckboxItem(WebInspector.UIString(WebInspector.useLowerCaseM
enuTitles() ? "Preserve log" : "Preserve Log"), preserveLogItemAction,
WebInspector.settings.preserveConsoleLog);

This string should be added to the WebCore/English.lproj/localizedStrings.js


More information about the webkit-reviews mailing list