[webkit-reviews] review canceled: [Bug 62211] [CMAKE] Replace "; " with space in FEATURE_DEFINES macro : [Attachment 96378] Modified Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 13 19:48:05 PDT 2011


Gyuyoung Kim <gyuyoung.kim at samsung.com> has canceled Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 62211: [CMAKE] Replace ";" with space in FEATURE_DEFINES macro
https://bugs.webkit.org/show_bug.cgi?id=62211

Attachment 96378: Modified Patch
https://bugs.webkit.org/attachment.cgi?id=96378&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
I'm not sure if WebCore/CMakeList.txt file is best place for the replacement.
I'd like to know which place is better ? 
(cmake/WebKitFeature.cmake or WebCore/CMakeLists.txt)


More information about the webkit-reviews mailing list