[webkit-reviews] review denied: [Bug 62613] No context for javascript parse errors. : [Attachment 97047] proposed patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Juan C. Montemayor
<jmont at apple.com>'s request for review:
Bug 62613: No context for javascript parse errors.
https://bugs.webkit.org/show_bug.cgi?id=62613

Attachment 97047: proposed patch
https://bugs.webkit.org/attachment.cgi?id=97047&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97047&action=review

The logic for this patch looks fine, however you need to have a slightly more
detailed changelog (basically saying what the change you're making is).

Normally you'd be expected to have a new testcase for this, but i suspect if
you do run-webkit-tests you'll see a large number of failures due to the
changed output.  Depending on what the changes are we may consider the new test
outputs to be sufficient on their own, otherwise you'll need to write a new
test specifically.

r- due to the test problem.

> Source/JavaScriptCore/ChangeLog:7
> +

You should have a more detailed description here.