[webkit-reviews] review denied: [Bug 62518] If an Event Listener is a Function, It Should be Called and Not Checked for handleEvent : [Attachment 96926] [PATCH] Improved Patch Following Conventions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 13 17:29:10 PDT 2011
Sam Weinig <sam at webkit.org> has denied Rob Brackett <rob at robbrackett.com>'s
request for review:
Bug 62518: If an Event Listener is a Function, It Should be Called and Not
Checked for handleEvent
https://bugs.webkit.org/show_bug.cgi?id=62518
Attachment 96926: [PATCH] Improved Patch Following Conventions
https://bugs.webkit.org/attachment.cgi?id=96926&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96926&action=review
I think we should probably audit all the other places where we handle the
"handleEvent" case and ensure that we are being consistent.
>> LayoutTests/ChangeLog:12
>> + * dom/html/level3: Added.
>
> I believe the tests under dom/html/level* are the W3C's published test
suites. So you probably don't want to put this here. What about something under
fast/events?
Dominic is right, you should create a new test under fast/events.
More information about the webkit-reviews
mailing list