[webkit-reviews] review granted: [Bug 62600] Make it possible to inline the common case of identifier parsing : [Attachment 97011] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 62600: Make it possible to inline the common case of identifier parsing
https://bugs.webkit.org/show_bug.cgi?id=62600

Attachment 97011: Patch
https://bugs.webkit.org/attachment.cgi?id=97011&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97011&action=review

> Source/JavaScriptCore/parser/Lexer.h:92
> +	   JSTokenType lexExpectIdentifier(JSTokenData* lvalp, JSTokenInfo*
llocp, unsigned, bool strictMode);

lvalp, llocp
(1) These are not necessary in the header.
(2) Say 20 Hail Marys, and please to be making these variables to have the
better names.