[webkit-reviews] review denied: [Bug 62283] [Qt] Support for the gnash flash player plugin : [Attachment 96424] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 13 15:25:55 PDT 2011
Eric Seidel <eric at webkit.org> has denied Dawit A. <adawit at kde.org>'s request
for review:
Bug 62283: [Qt] Support for the gnash flash player plugin
https://bugs.webkit.org/show_bug.cgi?id=62283
Attachment 96424: proposed patch
https://bugs.webkit.org/attachment.cgi?id=96424&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96424&action=review
Do we not have any tests in the repository which use flash?
> Source/WebCore/ChangeLog:10
> + No new tests. (OOPS!)
The OOPS in this line will cause your patch to fail the commit queue. You need
to replace this line with a list of tests or reasons why testing is
impossible/impractical.
More information about the webkit-reviews
mailing list