[webkit-reviews] review denied: [Bug 62423] [Chromium] Add WebSettings::setShouldPrintBackgrounds() : [Attachment 97000] Added comment to ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 13 15:20:57 PDT 2011
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied review:
Bug 62423: [Chromium] Add WebSettings::setShouldPrintBackgrounds()
https://bugs.webkit.org/show_bug.cgi?id=62423
Attachment 97000: Added comment to ChangeLog
https://bugs.webkit.org/attachment.cgi?id=97000&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97000&action=review
You forgot to set the '?' on the patch, which meant that it didn't
go into the review request queue :-(
> WebKit/chromium/ChangeLog:5
> + [Chromium] Add a WebSetting to control printing backgrounds
sorry to give you a hard time, but you are also supposed to include
the URL of this bug report here. please take a look at how other
people write ChangeLog entries.
More information about the webkit-reviews
mailing list