[webkit-reviews] review denied: [Bug 62593] Optimization: do a single fillRect when painting the background in RenderBoxModelObject::paintFillLayerExtended : [Attachment 96999] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Una Sabovic <una.sabovic at palm.com>'s
request for review:
Bug 62593: Optimization: do a single fillRect when painting the background in
RenderBoxModelObject::paintFillLayerExtended
https://bugs.webkit.org/show_bug.cgi?id=62593

Attachment 96999: proposed patch
https://bugs.webkit.org/attachment.cgi?id=96999&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96999&action=review

There is no need here to make any of the calls to isValid. Any color that is
not valid will also have an alpha of zero. Instead all the code can just check
for non-zero alpha values.

We’d like to eliminate the concept of “valid” entirely from Color, so it’s best
not to add more checks for validity.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:748
> +	       baseColor = view()->frameView()->baseBackgroundColor();
> +	       if (baseColor.alpha() == 0)
> +		   baseColor.setRGB(0, 0, 0);

Will this do the same thing as the old code if the base color has an alpha of
50%? I don’t think it will.