[webkit-reviews] review granted: [Bug 62584] Make it possible to inline Identifier::equal : [Attachment 96984] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 13 12:02:25 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 62584: Make it possible to inline Identifier::equal
https://bugs.webkit.org/show_bug.cgi?id=62584

Attachment 96984: Patch
https://bugs.webkit.org/attachment.cgi?id=96984&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96984&action=review

> Source/JavaScriptCore/runtime/Identifier.h:138
> +    inline bool Identifier::equal(const StringImpl* r, const UChar* s,
unsigned length)

Why isn't it const?


More information about the webkit-reviews mailing list