[webkit-reviews] review granted: [Bug 62509] Factor IconController out of FrameLoader : [Attachment 96877] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 13 11:39:04 PDT 2011
Nate Chapin <japhet at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 62509: Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509
Attachment 96877: Patch
https://bugs.webkit.org/attachment.cgi?id=96877&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96877&action=review
This is awesome. Just one question :)
> Source/WebCore/loader/icon/IconController.h:51
> + KURL url();
> + IconURLs urls(int iconTypes);
Is there anything we can do to make these names more distinct?
More information about the webkit-reviews
mailing list