[webkit-reviews] review requested: [Bug 62498] Additional FontCache::FontCachePurgePreventer instances needed : [Attachment 96980] Patch with additional instances of FontCachePurgePreventer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 13 11:28:47 PDT 2011
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 62498: Additional FontCache::FontCachePurgePreventer instances needed
https://bugs.webkit.org/show_bug.cgi?id=62498
Attachment 96980: Patch with additional instances of FontCachePurgePreventer
https://bugs.webkit.org/attachment.cgi?id=96980&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
Used several techniques to find additional locations to add
FontCachePurgePreventer instances.
- The traceback from this bug.
- A radar <rdar://problem/9588525> with code inspection
- In FontCache.cpp, set cMaxInactiveFontData and cTargetInactiveFontData to 0
which forces purging inactive fonts after last nested FontCachePurgePreventer
is destructed. Built webkit with this temp change and run tests looking for
ASSERT failure.
- Code inspection of platform code that calls either Font::drawText() or
Canvas::drawText().
More information about the webkit-reviews
mailing list