[webkit-reviews] review granted: [Bug 56935] [Qt] Implement accelerated compositing on WK2 Qt port : [Attachment 96962] Patch 2: WebGraphicsLayer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 13 10:49:37 PDT 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 56935: [Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935
Attachment 96962: Patch 2: WebGraphicsLayer
https://bugs.webkit.org/attachment.cgi?id=96962&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96962&action=review
> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:50
> +static const float gTileDimension = 1024.0;
I would put this above the hash map
> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:87
> + static WebLayerID sID = 1000;
Add comment why we start at 1000.
More information about the webkit-reviews
mailing list