[webkit-reviews] review granted: [Bug 62547] kAXTextMarkerForPositionParameterizedAttribute does not work correctly in WK2 : [Attachment 96969] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 62547: kAXTextMarkerForPositionParameterizedAttribute does not work
correctly in WK2
https://bugs.webkit.org/show_bug.cgi?id=62547

Attachment 96969: patch
https://bugs.webkit.org/attachment.cgi?id=96969&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96969&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:610
> +    void screenToWindow(const WebCore::IntPoint& point, WebCore::IntPoint&
result);

The stylebot suggests leaving out the name “point” here, and I agree. Unless
you want to call this screenPoint.

> Source/WebKit2/UIProcess/WebPageProxy.messages.in:55
> +    ScreenToWindow(WebCore::IntPoint point) -> (WebCore::IntPoint
resultPoint)

I’d call these screenPoint and windowPoint rather than point and resultPoint.