[webkit-reviews] review granted: [Bug 62180] nrwt: fix http, websocket server startup, shutdown : [Attachment 96844] rebasing again
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 13 10:02:07 PDT 2011
Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 62180: nrwt: fix http, websocket server startup, shutdown
https://bugs.webkit.org/show_bug.cgi?id=62180
Attachment 96844: rebasing again
https://bugs.webkit.org/attachment.cgi?id=96844&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96844&action=review
> Tools/Scripts/webkitpy/layout_tests/port/http_server.py:192
> + try:
> + self._remove_log_files(self._output_dir, "access.log-")
> + except OSError, e:
> + _log.warning('Failed to remove old %s log files' % self._name)
> + try:
> + self._remove_log_files(self._output_dir, "error.log-")
> + except OSError, e:
> + _log.warning('Failed to remove old %s log files' % self._name)
Nit: A for loop would be a bit more succinct, but this is OK too.
More information about the webkit-reviews
mailing list