[webkit-reviews] review denied: [Bug 50173] corrupted pointer in webkit_web_view_get_resource : [Attachment 96960] correct version of previous patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 13 09:56:02 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied  review:
Bug 50173: corrupted pointer in webkit_web_view_get_resource
https://bugs.webkit.org/show_bug.cgi?id=50173

Attachment 96960: correct version of previous patch
https://bugs.webkit.org/attachment.cgi?id=96960&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96960&action=review

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4837
> +    g_object_ref(webView);

Please leave a comment here explaining that we want to keep the WebKitWebView
alive until we have finished loading the main resource. You should also mention
that the same approach is taken in the Mac port.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4855
>	   priv->mainResource = 0;
>      } else
>	 g_hash_table_remove(priv->subResources.get(), identifier);
> +
> +    g_object_unref(webView);

Here you should only unref the WebView if the main resource is done loading.


More information about the webkit-reviews mailing list