[webkit-reviews] review granted: [Bug 62448] [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space : [Attachment 96953] update change log

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted KwangHyuk
<hyuki.kim at samsung.com>'s request for review:
Bug 62448: [EFL] change of cairo_format_t corresponding to
EVAS_COLORSPACE_ARGB8888 color space
https://bugs.webkit.org/show_bug.cgi?id=62448

Attachment 96953: update change log
https://bugs.webkit.org/attachment.cgi?id=96953&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96953&action=review

> Source/WebKit/efl/ChangeLog:12
> +	   As GraphicContextCairo is using CAIRO_FORMAT_ARGB32 as default
> +	   cairo_format_t, ewk better to use CAIRO_FORMAT_ARGB32 too instead of

> +	   CAIRO_FORMAT_RGB24, since pixman does not support the fast path from

> +	   src:argb32 to dst:rgb24 for source over operation when pixman is
using
> +	   bilinear filter

The English could be improved a bit there.

Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for
converting from ARGB32 to AGB24 when using source over operation in combination
with a bilinear filter. 

Or similar :-) Not sure if that is exactly what you are saying though.