[webkit-reviews] review granted: [Bug 62527] [EFL][WK2] Change string operation to makeString() : [Attachment 96918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 13 07:22:11 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 62527: [EFL][WK2] Change string operation to makeString()
https://bugs.webkit.org/show_bug.cgi?id=62527

Attachment 96918: Patch
https://bugs.webkit.org/attachment.cgi?id=96918&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96918&action=review

> Source/WebKit2/ChangeLog:6
> +	   [EFL][WK2] Change string operation to makeString()
> +	   https://bugs.webkit.org/show_bug.cgi?id=62527

Please add one line explaining why, like why that makes sense, why that is
better etc? 

like 'use makeStrings() instead of creating individual strings and
concatenating them'


More information about the webkit-reviews mailing list