[webkit-reviews] review requested: [Bug 61272] [Chromium] On-the-spot IME support for windowless plug-ins : [Attachment 96943] Patch v3

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 61272: [Chromium] On-the-spot IME support for windowless plug-ins
https://bugs.webkit.org/show_bug.cgi?id=61272

Attachment 96943: Patch v3
https://bugs.webkit.org/attachment.cgi?id=96943&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Tony and Tamura-san,

Thank you for your reviews and comments.

> Sorry, I misread your StringBuilder as StringBuffer. Using StringBuilder
makes sense.

I have updated my change to use StringBuilder.

(In reply to comment #11)
> do these become WebInputEvents that would never be passed to
WebWidget::handleInputEvent?

Right. This is only used for plug-ins.

> i'm concerned about defining plugin-specific input events.  can you tell me
more about
> why these are input events for plugins and not input events for WebWidgets? 
why wouldn't
> we just add methods for setting and confirming composition on WebPlugin?

Thank you for your comment. I have also considered this option before I started
implementing this change. In brief, I have added an input event just because an
IME event was mostly coupled with a keyboard events and it looked safer to use
the same framework that sends keyboard events to send IME events. I'm not sure
which is the better option in terms of sharing code between Chromium and
Safari, adding an input event or adding a method to WebPlugin. Unfortunately,
my Safari change for this issue is still in progress. (Even though this change
is currently a Chromium-specific change, I would like to share code with Safari
Win as much as possible.)

Regards,

Hironori Bono