[webkit-reviews] review denied: [Bug 50173] corrupted pointer in webkit_web_view_get_resource : [Attachment 96876] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 12 07:07:55 PDT 2011


Xan Lopez <xan.lopez at gmail.com> has denied  review:
Bug 50173: corrupted pointer in webkit_web_view_get_resource
https://bugs.webkit.org/show_bug.cgi?id=50173

Attachment 96876: proposed fix
https://bugs.webkit.org/attachment.cgi?id=96876&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
When we remove the main resource we set its identifier to the empty string "",
so unless there's a good reason not to I'd rather set it to "" initially too.
That would make this method just fail gracefully and return NULL without the
need for a g_return_val_if_fail.


More information about the webkit-reviews mailing list