[webkit-reviews] review granted: [Bug 62491] Flash of white on left and right edges of screen when showing fullscreen controller when movie doesn't fill the entire screen : [Attachment 96845] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 62491: Flash of white on left and right edges of screen when showing
fullscreen controller when movie doesn't fill the entire screen
https://bugs.webkit.org/show_bug.cgi?id=62491

Attachment 96845: Patch
https://bugs.webkit.org/attachment.cgi?id=96845&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96845&action=review

Looks great to me, but you said Simon should review it. I am setting review+
but I am not Simon!

> Source/WebCore/rendering/RenderLayerBacking.cpp:314
> +	   // Special case the RenderFullScreen case because we know its
> +	   // style does not come from CSS and it is therefore safe to set
> +	   // the layer's background color to the renderer's style's background

> +	   // color.
> +	   updateBackgroundColor();

This comment says why it’s safe to use updateBackgroundColor here, but not why
it’s important to use it (to avoid flashes you would see if we used a tiled
layer).

Also, the statement “its style does not come from CSS” does not clearly express
to me why it’s safe to use the background color. It’s tantalizingly close to
saying why, but doesn’t quite make it clear.

Also, that orphaned word color bugs me ;-)