[webkit-reviews] review denied: [Bug 62480] WebKit2: improve first page load speed by adding API to launch WebProcess earlier : [Attachment 96793] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 10 18:15:52 PDT 2011
Sam Weinig <sam at webkit.org> has denied Stephanie Lewis <slewis at apple.com>'s
request for review:
Bug 62480: WebKit2: improve first page load speed by adding API to launch
WebProcess earlier
https://bugs.webkit.org/show_bug.cgi?id=62480
Attachment 96793: patch
https://bugs.webkit.org/attachment.cgi?id=96793&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96793&action=review
> Source/WebKit2/UIProcess/API/C/WKContext.cpp:104
> + toImpl(contextRef)->ensureWebProcess();
This should call a function on WebContext that matches the suffix of the API
function call and the logic should be in WebContext.
> Source/WebKit2/UIProcess/API/C/WKContext.h:116
> +WK_EXPORT void WKContextLaunchInjectedBundle(WKContextRef context);
This isn't a good name for this. How about WKContextWarmInitialProcess(...).
I also think this should go in WKContextPrivate.h
More information about the webkit-reviews
mailing list