[webkit-reviews] review denied: [Bug 62194] new-run-webkit-tests: 'images' links on results.html don't work : [Attachment 96808] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 15:51:26 PDT 2011


Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 62194: new-run-webkit-tests: 'images' links on results.html don't work
https://bugs.webkit.org/show_bug.cgi?id=62194

Attachment 96808: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=96808&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96808&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:119
> +    def output_filename(self, modifier, local=False):

I'd rather you just create an output_testname method. I think that results in
better self-documenting code.


More information about the webkit-reviews mailing list