[webkit-reviews] review denied: [Bug 58159] dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml : [Attachment 96802] Converted to a text dump.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 10 15:30:21 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied Wyatt Carss <wcarss at google.com>'s
request for review:
Bug 58159: dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=58159
Attachment 96802: Converted to a text dump.
https://bugs.webkit.org/attachment.cgi?id=96802&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96802&action=review
Are you speculatively changing expected.txt for all platforms? I don't think
that'll work. I suggest you delete all platform-specific results and add
platform-independent result in editing/pasteboard/paste-xml.xhtml. You can
then add platform-specific results for each port on which the test fails.
> LayoutTests/platform/chromium/test_expectations.txt:3222
> -BUGWK58158 : editing/pasteboard/paste-xml.xhtml = PASS TEXT
> +BUGWK58158 : editing/pasteboard/paste-xml.xhtml = PASS
You should remove this entry if the test really passes.
More information about the webkit-reviews
mailing list