[webkit-reviews] review denied: [Bug 62149] Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on. : [Attachment 96253] Patch with fixes

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 62149: Web Inspector: [Chromium] DevTools does not highlight elements when
accelerated compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=62149

Attachment 96253: Patch with fixes
https://bugs.webkit.org/attachment.cgi?id=96253&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96253&action=review

This is looking great overall.	My main concern is the same as Vangelis' - it
seems that this code will create a new PageOverlay on every call to
highlightNode(), which is super frequent.  Can you look into that?

> Source/WebKit/chromium/src/PageOverlay.cpp:57
> +    update();

is this call just to run the code at lines 129-132?  can you just move that
cleanup code directly to here? i realize that probably means adding an #if
USE(ACCELERATED_COMPOSITING) block here but that feels less weird than calling
a member function inside a destructor

> Source/WebKit/chromium/src/PageOverlay.h:60
> +    PageOverlay(WebViewImpl*, PageOverlayClient*);
> +    WebViewImpl* m_viewImpl;

super-nitpicky nitpick: would prefer a newline between the last member function
and the first member variable, just to make this a bit easier to scan