[webkit-reviews] review denied: [Bug 60817] [chromium] Composited rendering mode for plugins : [Attachment 94718] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 60817: [chromium] Composited rendering mode for plugins
https://bugs.webkit.org/show_bug.cgi?id=60817

Attachment 94718: Patch
https://bugs.webkit.org/attachment.cgi?id=94718&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I dislike having a big bag of properties exposed on every layer that don't
currently do anything.	I think the shape of the eventual best design will
depend in large part by how flexible the plugin layer system ends up being.

IMO a better approach is to start by looking at what the pepper API will
expose, and then figure out how to best integrate that in with the compositor
infrastructure.  If the pepper API ends up exposing something relatively simple
(such as just an ordered list of plugin-sized textures of different types) then
the whole WebPluginLayer system can be a lot simpler and this can all be
reasonably handled as one LayerChromium.  If the pepper API is going to allow
setting up complex geometry + properties on many layers then we need to rethink
the approach.  In this patch there's a very rich API exposed but it isn't
actually implemented which worries me about how complex the eventual
implementation will end up being.